material-components / material-components/material-components-android

[MaterialTimePicker] Buttons at the bottom are getting cut off

Open
#3,584 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Widget: TimePicker
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

**Description:** `MaterialTimePicker` is getting its buttons cut off
at the bottom in the `1.11.x` releases, this looks correct in `1.10.0-beta01`
so it may be a regression.

I suspect this might improve if those two buttons are also constrained
to `parent` at their bottom edge.

**Expected behavior:** The expected behaviour is that those buttons
would not be clipped. Here are two screenshots - one from `1.10` and
one from `1.11`, notice how the dialog's height is less than it was in `1.10`
and the buttons are clipped:

1.10|1.11
-|-
![Screenshot_1694795666](https://github.com/material-components/material-components-android/assets/71154/463371b3-5efd-478b-a62d-e9bf9a579836)|![Screenshot_1694795666 copy](https://github.com/material-components/material-components-android/assets/71154/1cebbfc7-fc0e-4e76-bf9d-8ab0ad29d32f)

**Source code:** `material_timepicker_dialog.xml`; This may be due to
commit d10201dc88f919421b3bc4d8d7aa432de685c892 which updated the layout

**Minimal sample app repro:** n/a

**Android API version:** 33

**Material Library version:** 1.11.0-alpha02

**Device:** Pixel 6 emulator

To help us triage faster, please check to make sure you are using the [latest version](https://github.com/material-components/material-components-android/releases) of the library.

We also happily accept [pull requests](https://github.com/material-components/material-components-android/pulls).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with material_timepicker_dialog.xml and compare its current constraints with the layout before commit d10201dc88f919421b3bc4d8d7aa432de685c892. Check how the bottom buttons are constrained and verify the MaterialTimePicker dialog on Android API 33. Done means both buttons are fully visible rather than clipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.