material-components / material-components/material-components-android
[Carousel] Update mask size when MaskableFrameLayout size is changed
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
Looks like https://github.com/material-components/material-components-android/commit/14023d2c8589a515ae0d80f75f301077aa324f08 was rolled back by https://github.com/material-components/material-components-android/commit/64b066a0c46e78f2c41403dd566fbc1ce8125b66. Would you mind reopening and re-reviewing my PR?
_Originally posted by @pubiqq in https://github.com/material-components/material-components-android/issues/3450#issuecomment-1644714356_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Carousel and MaskableFrameLayout entry points, then review commits 14023d2c8589a515ae0d80f75f301077aa324f08 and 64b066a0c46e78f2c41403dd566fbc1ce8125b66 plus issue 3450. Done means the mask size updates when the MaskableFrameLayout size changes and the prior change is ready for re-review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100