material-components / material-components/material-components-android
[Chip] Request: add clicking effect for Chip
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
**Is your feature request related to a problem? Please describe.**
Yes.
Pressing on the chip, there is no feedback that it's being pressed.
**Describe the solution you'd like**
Have a ripple effect for clicking (and long clicking), and also offer a way to customize it (ripple effect color, or a different background for the clicking effect).
**Describe alternatives you've considered**
I tried to use each of these, but it didn't work:
- app:chipBackgroundColor="?attr/selectableItemBackground" - it made it look like a checkbox on design mode, and crash during runtime. Shouldn't it be considered a bug, as it should show some warning in design mode?
- android:background="?attr/selectableItemBackground" - doesn't do anything at all.
**Additional context**
[scrcpy_2023-07-02_14-36-36.zip](https://github.com/material-components/material-components-android/files/11929352/scrcpy_2023-07-02_14-36-36.zip)
[My Application.zip](https://github.com/material-components/material-components-android/files/11929353/My.Application.zip)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Chip component and reproducing the missing press feedback using the attached application context. Done means Chip provides feedback for click and long-click interactions and a way to customize the effect color or pressed background; no file or test is named, so the implementation scope needs clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100