material-components / material-components/material-components-android

[Time Picker ] Chip background color not changing when switch to INPUT_MODE_KEYBOARD

Open
#3,454 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Widget: TimePicker
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

**Description:** Full description of the issue here

Chip background color working in INPUT_MODE_CLOCK

![Screenshot_20230620-131601 (1)](https://github.com/material-components/material-components-android/assets/2860225/461efe28-00d5-4cd7-9241-9acd90c1d0a0)

When I switch to INPUT_MODE_KEYBOARD the Chip background color not working

![Screenshot_20230622-113052](https://github.com/material-components/material-components-android/assets/2860225/8746c3ee-2c6c-4283-9be7-40a14e9255bb)

**Source code:**


<item name="chipStyle">@style/TimePickerTheme.Chip</item>
<item name="colorSurface">@color/colorSurface</item>
<item name="android:colorPrimary">@color/color_orange_100</item>
<item name="materialClockStyle">@style/TimePickerTheme.Clock</item>
<item name="borderlessButtonStyle">@style/TimePickerTheme.BorderlessButtonStyle</item>
<item name="materialButtonOutlinedStyle">@style/TimePickerTheme.BorderOutlineStyle</item>
<item name="materialTimePickerTitleStyle">@style/headline_4</item>


<item name="clockHandColor">@color/color_orange_100</item>
<item name="clockFaceBackgroundColor">@color/time_picker_clock_color</item>
<item name="clockNumberTextColor">@color/colorOnSurface</item>


<item name="chipBackgroundColor">@color/time_picker_chip_selector</item>
<item name="android:textAppearance">@style/hds</item>
<item name="android:textColor">@color/colorOnSurface</item>


<item name="android:textColor">@color//color_orange_100</item>
<item name="android:textAppearance">@style/button.large</item>
<item name="strokeWidth">0dp</item>


<item name="android:textColor">@color/colorOnPrimary</item>
<item name="android:textAppearance">@style/headline_6</item>
<item name="android:backgroundTint">@color/time_picker_border_button_selector</item>



**Minimal sample app repro:** Please consider attaching a minimal sample app that reproduces the issue. This will help narrow down the conditions required for reproducing the issue, and it will speed up the bug fix process. You may attach a zip file of the sample app or link to a GitHub repo that contains the sample app.

**Android API version:** Android 13

**Material Library version:** 1.8.0

**Device:** Checked on Pixel 4

To help us triage faster, please check to make sure you are using the [latest version](https://github.com/material-components/material-components-android/releases) of the library.

We also happily accept [pull requests](https://github.com/material-components/material-components-android/pulls).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Material Library 1.8.0 on Android 13 using the provided TimePickerTheme styles, then inspect the MaterialTimePicker entry point and its INPUT_MODE_KEYBOARD chip state handling. Done means the chip background color follows the supplied selector after switching from INPUT_MODE_CLOCK to INPUT_MODE_KEYBOARD.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.