material-components / material-components/material-components-android

[TimePicker] Expose Builder Options to Set Hour and Minute Text Labels

Open
#3,352 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting Design Feedback Issue: Internationalization Widget: TimePicker
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

The MaterialTimePicker builder currently has functions to set the title text, positive button text, and negative button text. Would like a way to also set the text for the hour and minute field labels so that we can support localization fully when using this component.

Screen Shot 2023-04-18 at 10 45 05 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MaterialTimePicker and its Builder, then inspect the existing title, positive-button, and negative-button text options and the code that renders the hour and minute field labels. Check nearby tests for builder text customization; done means callers can provide localized hour and minute labels through the builder and the component displays them.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.