material-components / material-components/material-components-android
[ActionMode] Icons color for disabled/enabled state is the same in the night theme
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
Description: The color of the icons (in my case - delete icon) in the dark theme in action mode is the same regardless of whether it is enabled or disabled.
https://user-images.githubusercontent.com/4838367/222810874-50d277cc-ffc9-4c9b-bf22-cb3700218548.mp4
Expected behavior: Light theme
https://user-images.githubusercontent.com/4838367/222810897-3f678287-fa5b-47b7-9edb-6717f1354c76.mp4
Source code:
Light theme (default):
<resources xmlns:tools="http://schemas.android.com/tools">
<!-- Base application theme. -->
<style name="Theme.Notes" parent="Theme.Material3.DayNight.NoActionBar">
<!-- Primary brand color. -->
<item name="colorPrimary">@color/purple_500</item>
<item name="colorPrimaryVariant">@color/purple_700</item>
<item name="colorOnPrimary">@color/white</item>
<!-- Secondary brand color. -->
<item name="colorSecondary">@color/teal_200</item>
<item name="colorSecondaryVariant">@color/teal_700</item>
<item name="colorOnSecondary">@color/black</item>
<!-- Status bar color. -->
<item name="android:statusBarColor">@android:color/transparent</item>
<!-- Customize your theme here. -->
<item name="android:windowLightStatusBar">true</item>
<item name="windowActionModeOverlay">true</item>
</style>
</resources>
Dark theme:
<resources xmlns:tools="http://schemas.android.com/tools">
<!-- Base application theme. -->
<style name="Theme.Notes" parent="Theme.Material3.DayNight.NoActionBar">
<!-- Primary brand color. -->
<item name="colorPrimary">@color/purple_200</item>
<item name="colorPrimaryVariant">@color/purple_700</item>
<item name="colorOnPrimary">@color/black</item>
<!-- Secondary brand color. -->
<item name="colorSecondary">@color/teal_200</item>
<item name="colorSecondaryVariant">@color/teal_200</item>
<item name="colorOnSecondary">@color/black</item>
<!-- Status bar color. -->
<item name="android:statusBarColor">@android:color/transparent</item>
<!-- Customize your theme here. -->
<item name="windowActionModeOverlay">true</item>
</style>
</resources>
Android API version: 30
Material Library version: 1.8.0, 1.9.0-alpha02
Device: POCO X3 NFC
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing ActionMode with the supplied light and dark theme values on Android API 30 and Material Library 1.8.0 or 1.9.0-alpha02. Done means enabled and disabled icons have visibly distinct colors in the night theme, matching the light-theme distinction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android
- Domain
- design, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100