material-components / material-components/material-components-android

[CircularProgressIndicator] visibilityAfterHide is ignored.

Open
#3,217 0 comments 0 reactions 1 assignee View on GitHub

@pekingme is already working on this.

Since Feb 6, 2023.

bug Widget: ProgressIndicator
Dominant language
Java
Stars
17.4k
Forks
3.2k
No merged PRs in 30d

Description

Description: When hiding a progress indicator using the hide() method, it always set the View visibility to INVISIBLE instead of setting it to the value set to visibilityAfterHide

https://github.com/material-components/material-components-android/blob/2e7979b60bb22b57a070f0ad46abee17ec97e634/lib/java/com/google/android/material/progressindicator/BaseProgressIndicator.java#L248-L256

Expected behavior: Calling hide() after setVisibilityAfterHide(View.GONE) set the view visibility to GONE instead of INVISIBLE

Android API version: Any

Material Library version: 1.8.0

Device: Any

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.