material-components / material-components/material-components-android
[BottomSheetDialogFragment] significantVelocityThreshold does not impact nested scrolling
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
The nested scrolling sensibility of the BottomSheetDialogFragment is too sensible, a minimum scroll makes the dialog dismiss.
In the 1.8.0-alpha01 version is possible to set the 'significantVelocityThreshold' in the dialog behavior to adjust the theshold, but it does not impact the nested scrolling.
Expected behavior: Here you can find a video that describes the issue
https://streamable.com/gu3x1g
Source code: That's my dialog behavior configuration
dialog.behavior.skipCollapsed = true
dialog.behavior.isFitToContents = true
dialog.behavior.significantVelocityThreshold = Int.MAX_VALUE
dialog.behavior.state = BottomSheetBehavior.STATE_EXPANDED
Material Library version: 1.8.0-alpha01
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the nested-scrolling behavior with the provided BottomSheetDialogFragment configuration on Material Library 1.8.0-alpha01, then trace BottomSheetBehavior's nested-scroll handling and use of significantVelocityThreshold. Done means setting the threshold changes the minimum scroll needed to dismiss the dialog.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100