material-components / material-components/material-components-android
[BottomSheetBehavior] Support child's marginTop
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
Currently `BottomSheetBehavior` with `marginTop` behaves badly - child jumps on screen depending on layout phase and appears in different places when showing
Also it's impossible to use both `fisToContents` and expanded offset. The only workaround is to set `marginTop` to `CoordinatorLayout`, however this greatly limits other views in this parent
The solution is to support `marginTop` as if it were with an expanded offset compatible with `fisToContents`.
One possible soulution is proposed in #2094
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with BottomSheetBehavior and review the solution proposed in issue #2094. Verify the behavior during layout and showing, then confirm that child marginTop works consistently with fitToContents and an expanded offset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100