material-components / material-components/material-components-android
[Top App Bar] Specify that either AppBarLayout or MaterialToolbar should be themed or transparent in the doc
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17.4k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Description
**Is your feature request related to a problem? Please describe.**
The doc doesn't say any about the relationship of `AppBarLayout` and `MaterialToolbar`, but in their code I found that only one of them should be themed (taking an `style` property in the layout, and you have to theme one of them (otherwise the appbar could be very strange).
Moreover, the in collapsible layout, only the `AppBarLayout`'s style will take effect.
**Describe the solution you'd like**
In the doc, add instructions about their relationship and what should take a `style` property under each circumstance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Top App Bar documentation and inspect the AppBarLayout and MaterialToolbar guidance and code behavior described in the issue. Clarify which component should receive a style in each layout circumstance, including collapsible layouts, and mark the work done when the documentation explains the relationship and styling choices.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android
- Domain
- documentation, mobile
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100