material-components / material-components/material-components-android

[ExtendedFloatingActionButton] shrink not work with Motionlayout

Open
#1,090 3 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Widget: FloatingActionButton
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Th ExtendedFloatingActionButton does't shrink when it's a child of a Motionlayout. I think because it update its size in the with:
`layoutParams.width = size.getWidth()`
`layoutParams.height = size.getHeight()`
(in ` ChangeSizeStrategy.performNow() `)

which shouldn't be done like that when the `layoutParams` is a `ConstraintLayout.LayoutParams`.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ChangeSizeStrategy.performNow(), especially the layoutParams width and height updates described in the issue. Inspect how ExtendedFloatingActionButton behaves as a child of MotionLayout, and verify that the shrink operation changes the button size correctly in that configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
design, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.