mateogianolio / mateogianolio/vectorious
blas `axpy` test is not meaningful
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 918
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
The axpy test checks that the return value of axpy is the same as the return value of nblas.daxpy. These functions actually have return type void so the check is just that undefined === undefined!
The actual thing saxpy/daxpy should do is mutate y in place.
https://github.com/mateogianolio/vectorious/blob/3ec25615d3871224cbcb6f5bb3e154208faab276/src/blas.spec.ts#L17
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/blas.spec.ts at the axpy test referenced in the issue. Replace the return-value comparison with assertions that saxpy and daxpy mutate y in place as expected; the test is done when it verifies the resulting y values rather than undefined return values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100