matcornic / matcornic/hugo-theme-learn
The value of the `showhidden` parameter is not properly parsed (`children` shortcode)
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.6k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
the children shortcode does not work properly, because every value of the showhidden parameter seems to be interpreted as true, e.g.
{{% children showhidden="false" %}}
{{% children showhidden="anything" %}}
{{% children showhidden="true" %}}
Only {{% children showhidden="" %}} (empty string) seems to be interpreted as false.
Preferred solution: every value - except true - is interpreted as false.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the children shortcode implementation and trace how the showhidden parameter is parsed. Verify the existing behavior with false, arbitrary, true, and empty values; done means only true enables showing hidden children and the other values disable it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- hugo
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100