matcornic / matcornic/hermes

Removing the "," after {{.Email.Body.Signature}} in themes

Open
#53 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
3k
Forks
249
PR merge metrics
No merged PRs in 30d

Description

It would be great removing the "," after {{.Email.Body.Signature}} in the default/flat theme. When using the themes in other languages, the "," is not needed. So the theme would be more flexiable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Find the default/flat theme template containing {{.Email.Body.Signature}} and inspect how the signature is rendered. Remove the following comma, then verify that the generated theme output no longer includes it and remains suitable for other languages.

Written by the indexing model from the issue text.

Assessment

Domain
content
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.