matcornic / matcornic/hermes

Minimize themes

Open
#11 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
3k
Forks
249
PR merge metrics
No merged PRs in 30d

Description

Hi!
Would you consider minimizing the html/css themes?

For example we could:
- use https://github.com/tdewolff/minify when creating hermes.Hermes
- Create hermes.Hermes in a dedicated function like

```go
config := hermes.Config{
// Optional Theme
// Theme: new(Default)
Product: hermes.Product{
// Appears in header & footer of e-mails
Name: "Hermes",
Link: "https://example-hermes.com/",
// Optional product logo
Logo: "http://www.duchess-france.org/wp-content/uploads/2016/01/gopher.png",
},
}

h := hermes.New(config)
...

```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the hermes.Hermes creation path and the hermes.New(config) entry point, then inspect how the optional themes are rendered. Review whether the proposed tdewolff/minify integration fits there; done means generated HTML and CSS themes are minimized without changing the email output.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.