massgov / massgov/mayflower-react-starter

An in-range update of eslint-plugin-import is breaking the build 🚨

Open
#10 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

greenkeeper
Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

## The devDependency [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) was updated from `2.16.0` to `2.17.0`.

🚨 [View failing branch](https://github.com/massgov/mayflower-react-starter/compare/master...massgov:greenkeeper%2Feslint-plugin-import-2.17.0).

This version is **covered** by your **current version range** and after updating it in your project **the build failed**.

eslint-plugin-import is a devDependency of this project. It **might not break your production code or affect downstream projects**, but probably breaks your build or test tools, which may **prevent deploying or publishing**.

Status Details

- ❌ **ci/circleci: test:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/massgov/mayflower-react-starter/22?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

---

Commits

The new version differs by 61 commits.



  • 0499050 bump to v2.17.0

  • f479635 [webpack] v0.11.1

  • 8a4226d Merge pull request #1320 from bradzacher/export-ts-namespaces

  • 988e12b fix(export): Support typescript namespaces

  • 70c3679 [docs] make rule names consistent

  • 6ab25ea [Tests] skip a TS test in eslint < 4

  • 405900e [Tests] fix tests from #1319

  • 2098797 [fix] export: false positives for typescript type + value export

  • 70a59fe [fix] Fix overwriting of dynamic import() CallExpression

  • e4850df [ExportMap] fix condition for checking if block comment

  • 918567d [fix] namespace: add check for null ExportMap

  • 2d21c4c Merge pull request #1297 from echenley/ech/fix-isBuiltIn-local-aliases

  • 0ff1c83 [dev deps] lock typescript to ~, since it doesn’t follow semver

  • 40bf40a [*] [deps] update resolve

  • 28dd614 Merge pull request #1304 from bradennapier/feature/typescript-export-type


There are 61 commits in total.


See the full diff

FAQ and help

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

---

Your [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing branch linked in the issue and the CircleCI test details to identify what changed after eslint-plugin-import moved from 2.16.0 to 2.17.0. Trace the failure in the project's dependency and build configuration; done means the dependency update no longer causes the CircleCI test build to fail.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, javascript
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.