martimors / martimors/python-oauth-encrypt

Return response object from client

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Instead of raising for status and returning json object, just return the response object in the `get` method.
This will mimic the behaviour of the client in https://requests-oauthlib.readthedocs.io/en/latest/oauth2_workflow.html

https://github.com/dingobar/python-oauth-encrypt/blob/bda9270e3b2328b38cb65316e8a947bd7d941578/oauth_encrypt/client.py#L63

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in oauth_encrypt/client.py around line 63 and inspect the client’s get method. Change its result to match the requested response-object behavior instead of the current status-raising and JSON-returning behavior, then verify that the method’s observable result matches the requests-oauthlib workflow described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, authentication
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.