marstr / marstr/envelopes

Get Rid of the `Impact` type

Open
#64 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6
Forks
0
PR merge metrics
No merged PRs in 30d

Description

It was trying to add a way to prevent people from doing weird unintuitive things. After using it for a while, I don't think it accomplishes anything but making people cast variables all over the place.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Impact type and every place it is used in the Go packages. Review the casts and the surrounding budgeting and state code to understand what depends on it. Done means the type and unnecessary casts are removed without leaving broken package behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.