marstr / marstr/baronial

Unhelpful error message when providing bad "amount" value

Open
#79 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
13
Forks
0
PR merge metrics
No merged PRs in 30d

Description

System Information

Version:  v0.2.0-modified

System: windows/amd64
Go: go1.15.5
Source Revision: 26f4536fb5d055965e1f30acae1be8ad16438d25

## What did you do?

I tried to commit a transaction - but I accidentally used the "-a" flag instead of the "-t" flag to indicate the "Actual Time" of the transaction.

## What did you expect to happen?

An error message indicating which argument was invalid, what it got, what it expected, that kinda thing.

## What actually happened?

Error text that looks like its straight from the Go libraries `error` value showed up. Super unhelpful to a user, caused the author of this tool some pause, imagine what it would be like for other people.

Stack Trace

FATA[0000] unable to find balance in text

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the CLI handling for committing a transaction and trace how the amount value is parsed when -a is supplied instead of -t. Reproduce the reported command with the issue's system details, then make the completed behavior identify the invalid argument, its received value, and the expected value.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.