marstr / marstr/baronial

`make.bat` should detect when Perl is not installed

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue help wanted windows-only
Dominant language
Go
Stars
13
Forks
0
PR merge metrics
No merged PRs in 30d

Description

System Information

Version:  v0.1.1-modified

System: windows/amd64
Go: go1.12.7
Source Revision: af91355be2f7c0d8e5ec5ea2843d2964b7ab0ff9

## What did you do?

Clone this repository onto a Windows machine that does not have a perl install, and execute `.\make.bat install`

## What did you expect to happen?

`make.bat` should fail and report that perl must be installed to continue.

## What actually happened?

perl is invoked, but the installation continues anyway. This can lead to system information being reported that doesn't capture version/revision information, or even worse garbage being used for those values.

Stack Trace

[Copy&Paste the error message that you got here.]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running .\make.bat install on Windows without Perl installed, then inspect make.bat around the Perl invocation. Done means the script stops before installation and clearly reports that Perl must be installed, rather than continuing with missing or invalid version information.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, perl
Domain
build-system, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.