marshmallow-code / marshmallow-code/marshmallow
fields.Boolean should accept only json booleans
Open
Nobody has claimed this yet.
feedback welcome
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 738
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 7
Description
I don't see a point to allow fields.Boolean to accept values like 'F', 'f', '0', 0, 0.0 and etc. as valid ones. Why such decision was made?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the fields.Boolean entry point and inspect how it currently coerces string and numeric inputs. Check the existing validation coverage for Boolean values, then define completion as rejecting non-JSON booleans while preserving the accepted true and false cases and updating the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100