marshmallow-code / marshmallow-code/marshmallow
URL TLD IP Address Allowed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.2k
- Forks
- 738
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 7
Description
`require_tld` does not reject IP addresses in URL fields. The docs say it should "reject non-FQDN hostnames".
https://marshmallow.readthedocs.io/en/stable/api_reference.html?highlight=url#marshmallow.fields.Url
```python
from marshmallow import Schema, fields
class Test(Schema):
foo = fields.URL(require_tld=True) # default
Test().load({'foo': 'http://192.168.1.1/'})
# {'foo': 'http://192.168.1.1/'}
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating fields.URL and the require_tld validation path, using the example URL in the issue as the reproduction case. Add a regression test showing that an IP address is rejected when require_tld is true, and verify the existing URL validation tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100