marshmallow-code / marshmallow-code/marshmallow

Harmonize how modifiers are passed

Open
#1,244 0 comments 0 reactions 0 assignees View on GitHub
refactor
Dominant language
Python
Stars
7.2k
Forks
738
Avg merge
1d 23h
Merged PRs (30d)
7

Description

- ~~Rename `container` in to `inner`. Can be done quickly after #1229 is merged.~~ Done in #1243
- Harmonize the way the modifiers can be passed (as `Nested` parameters, as Meta params, at load time, in schema init, as string with dot delimiter, etc.).
- Merge `Schema._normalize_nested_options` and `Nested._nested_normalized_option` into a single method.

_Originally posted by @lafrech in https://github.com/marshmallow-code/marshmallow/pull/1066#issuecomment-498558303_

See also:

- https://github.com/marshmallow-code/marshmallow/pull/1066#issuecomment-498268715

Contributor guide

Open the contributing guide

Research direction

Start by reading Schema._normalize_nested_options and Nested._nested_normalized_option, then review the linked pull requests and their discussion. Trace how modifiers are accepted as Nested parameters, Meta parameters, at load time, in schema initialization, and as dot-delimited strings. Done means the modifier handling is harmonized and the two normalization methods are merged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.