marshmallow-code / marshmallow-code/marshmallow-oneofschema

Possible redundant assertion in test_validate

Open
#188 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
142
Forks
44
Avg merge
7h 7m
Merged PRs (30d)
3

Description

Hi,

There appear to be a duplicate assertion in [test_validate](https://github.com/marshmallow-code/marshmallow-oneofschema/blob/main/tests/test_one_of_schema.py#L278), which I'm not sure is intentional?

Contributor guide

Open the contributing guide

Research direction

Open tests/test_one_of_schema.py at test_validate around line 278 and compare the nearby assertions to determine whether one is duplicated. Check the surrounding test intent before deciding whether the redundant assertion should be removed, then run the relevant test file to confirm the test suite still passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.