marshmallow-code / marshmallow-code/marshmallow-oneofschema
Expect type_field_remove to remove the additional type-field in dump-Output
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 142
- Forks
- 44
- Avg merge
- 7h 7m
- Merged PRs (30d)
- 3
Description
When setting type_field_remove to True, I would expect that there is no additional type field in the output, when dumping a OneOfSchema-Class. But this is not the case. The type field is only removed in the _load-function, not in the _dump-function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the OneOfSchema implementation around type_field_remove, comparing the existing _load-function behavior with the _dump-function path. Reproduce dumping a OneOfSchema-Class with type_field_remove set to True, then verify that the output contains no additional type field and that existing behavior remains covered by the test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100