mars-project / mars-project/mars

Prevent fallback to numpy in the test cases for `numexpr` execution

Open
#652 1 comment 0 reactions 0 assignees View on GitHub
type: enhancement type: tests
Dominant language
Python
Stars
2.7k
Forks
325
PR merge metrics
No merged PRs in 30d

Description

We use `numexpr` to accelerate execution and test it in `test_numexpr_execute.py`, however, it will fallback to `numpy` when encounters unsupported operands, we should avoid this kind of fallback in tests to ensure that all supported operands are executed by `numexpr` rather than fallback to `numpy`.

Contributor guide

Open the contributing guide

Research direction

Start by reading test_numexpr_execute.py and trace how the tests invoke numexpr execution and permit fallback to numpy. Update the tests so supported operands are verified as running through numexpr rather than silently falling back, then run the relevant test file to confirm the fallback is detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
data, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.