mars-project / mars-project/mars

[BUG]Build fails under Windows platform

Open
#3,366 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.7k
Forks
325
PR merge metrics
No merged PRs in 30d

Description

**Bug description**
The MSVC team recently added Mars as part of RWC testing to detect compiler regression. Seems the project will fail to build under Windows due to error C1189: #error: unsupported platform. Could you please take a look?

**To Reproduce**
1. Open VS2022 x64 Tools command .
2. git clone C:\gitP\Tencent\mars C:\gitP\Tencent\mars(The commit SHA we use is 6c71f72)
3. Build project from scratch.

**Expected behavior**
Build passed.

**Additional context**
The problem seems to be that some compilation errors occurred when compiling the Mars project using Visual Studio 2022, which involved some header files of the OpenSSL library, resulting in error C1189: unsupported platform error.
[Build (3).log](https://github.com/mars-project/mars/files/15282079/Build.3.log)
Attached is the build log.
We found the problematic header file and found that line 16 caused the error. We have applied a patch to fix this issue.
[Mars_platform_fix.patch](https://github.com/mars-project/mars/files/15282111/Mars_platform_fix.patch)
If you need more information or have any questions, please leave a message under this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the build from scratch with the VS2022 x64 Tools command at commit 6c71f72, then inspect Build (3).log and the OpenSSL header identified as failing at line 16. Compare the reported Mars_platform_fix.patch with the affected header; done means the project builds successfully under Windows without C1189.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.