marmelab / marmelab/ng-admin

Failing file upload should result in an error message shown to the user

Open
#717 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
3.9k
Forks
703
PR merge metrics
No merged PRs in 30d

Description

No error message is shown on the client when a server-side request for file upload (sent upon choosing a file in the file browser) fails. The error is just ignored silently:

![screen shot 2015-10-06 at 11 26 48](https://cloud.githubusercontent.com/assets/351828/10304891/30e814d0-6c1d-11e5-8e09-d83202c871b0.png)

This is important, for instance, to tell the user that the uploaded file does not satisfy size or format restrictions.

Using `0.9.0-dev`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the client-side file-browser upload request and its failure handling. Reproduce a server-side upload failure, then verify that the user sees an error message explaining the rejected upload instead of the failure being ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.