marmelab / marmelab/ng-admin

File upload field

Open
#541 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.9k
Forks
703
PR merge metrics
No merged PRs in 30d

Description

The current version of the file upload is inapplicable IMO. You can use it only when updating the data object (e.g. user) because it doesn't work when on submit.

There are 2 problems. 1. the form doesn't have "enctype=multipart/form-data" and 2. when you submit the form the data gets serialized. At least I am very certain it does. Didn't investigate this too much.

I have created my own hard-coded/hacked version of this file upload but it is not ready to be packed into the ng-admin...

Is there any interest in adding this field or is this too advance and is OK that programmer must code this manually?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the file upload field and the form submission serialization; verify how the form encoding and submitted file data are handled. Done means the field works when creating data, not only when updating an existing object.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.