marmelab / marmelab/ng-admin

Add `password` type

Open
#526 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
3.9k
Forks
703
PR merge metrics
No merged PRs in 30d

Description

On an idea from @karantan.

The password type should have a different behavior between the creation and edition view.

In creation view, it should be a simple password field. We may add a confirmation, but not in a first time.

In edition view, we should not send the password back if not modified. So, we have to put a button allowing to change password. If not clicked, then we just ignore this field at form submission.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing type definitions and the creation and edit form entry points; the issue names no files or tests. Verify that creation accepts a password, while an unchanged edit omits it and a password change submits the new value.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.