marmelab / marmelab/ng-admin

deletionView and onSubmitSuccess/onSubmitError

Open
#1,106 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
3.9k
Forks
703
PR merge metrics
No merged PRs in 30d

Description

I think deletion view should have those two methods too.
This would allow you to have some custom actions after delete is done on server or custom handling if delete fails on server.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the deletionView implementation and the existing onSubmitSuccess/onSubmitError methods in the AngularJS codebase. Review how delete requests report success and failure, then confirm that deletionView exposes equivalent custom actions for both outcomes and that the behavior is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.