marmelab / marmelab/ng-admin

Fields inside embedded_list and validation

Open
#1,083 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
3.9k
Forks
703
PR merge metrics
No merged PRs in 30d

Description

I have embedded_list and inside this list some fields with validation.
Validation doesn't seem to work (fields don't turn red/green).

In addition if field doesn't pass validation an JS error "notification is not defined" seems to be generated and form is not submitted to server.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with fields that have validation inside an embedded_list, then trace the validation handling around the reported “notification is not defined” error. Done means invalid fields show their validation state and the form submits correctly when validation passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.