String ID with non-URLsafe chars causes 404 when viewing detail page
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3.9k
- Forks
- 703
- PR merge metrics
- No merged PRs in 30d
Description
I have an entity with a string ID field.
If the ID contains non-URLsafe chars like "+" or "/" then the detail links from the list view correctly escapes these chars, i.e. https://my-app.example.com/#/users/edit/x5ig%2BnkzATc%252FCBz , however following that link does not work:
I believe this is because the REST GET request for the user does not correctly escape the ID when using it as a URL parameter:
ng-admin.min.js:25 GET https://my-app.example.com/api/users/x5ig+nkzATc/CBz 404 (Not Found)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the detail-page REST GET request shown in ng-admin.min.js and compare how its ID parameter is encoded with the list-view detail link. Done means an entity whose string ID contains '+' or '/' can be opened from the list without the request becoming a 404.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angularjs, javascript
- Domain
- api, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100