marmelab / marmelab/EventDrops

draw() not supposed to redraw the chart?

Open
#283 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.3k
Forks
233
PR merge metrics
No merged PRs in 30d

Description

What you were expecting:

Following the documentation:

draw(config, scale) redraws chart using given configuration and d3.scaleTime scale

I was naively expecting that I could update the zoom in the chart (without recreating a new one) by giving it a new domain interval, such as:

var xScale = d3
        .scaleTime()
        .domain([new_start_date, new_end_date])

chart.draw(config, xScale);

So that the interval new_start_date and new_end_date would be in focus.

What happened instead:

Chart is not redrawn. Nothing happens.

Other information:

I am forced to use the package at https://unpkg.com/event-drops@1.3.0/dist/index.js as I have no way to run npm on this locked machine.

Environment

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior in Chrome using EventDrops 1.3.0 from the linked unpkg dist/index.js, focusing on chart.draw(config, xScale) with a new d3.scaleTime domain. Check whether the chart responds to the updated interval without recreation; done means the requested start and end dates are in focus after draw().

Written by the indexing model from the issue text.

Assessment

Tech stack
d3js, javascript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.