marl / marl/openl3

Clarification on input representation

Open
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
604
Forks
66
PR merge metrics
No merged PRs in 30d

Description

I was just reading through the source code on openl3 > core.py and noticed something in functions (1. _librosa_linear_frontend and 2. _librosa_mel_frontend). It seems librosa.power_to_db() is being used on a magnitude, not power spectrum? Instead should it be using librosa.amplitude_to_db()?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in core.py at _librosa_linear_frontend and _librosa_mel_frontend. Inspect the inputs passed to librosa.power_to_db() and compare them with the magnitude-versus-power distinction raised in the issue. Done means the expected representation is established for both functions and the issue is resolved or the required follow-up is clearly recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.