marl / marl/openl3

Add note to docs about embeddings changing after tensorflow 2 / kapre + librosa upgrade

Open
#80 0 comments 0 reactions 3 assignees View on GitHub

@justinsalamon is already working on this.

Since Aug 16, 2021.

Dominant language
Jupyter Notebook
Stars
604
Forks
66
PR merge metrics
No merged PRs in 30d

Description

@magdalenafuentes made a good point that we should add a note to the openl3 docs that mention that the embeddings are different after 0.4.0 so that people aren't caught off guard. And maybe we can include the plot that @hohsiangwu made showing the performance comparison between the different frontends and tensorflow versions

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.