marl / marl/jams-data

Rewrite SALAMI parser to use raw data

Open
#9 4 comments 0 reactions 1 assignee View on GitHub

@urinieto is already working on this.

Since Feb 3, 2016.

bug enhancement
Dominant language
Python
Stars
27
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Forking from https://github.com/craffel/mir_eval/issues/162 ; parsing the parsed salami annotations could lead to errors. We should instead work on the raw version of the annotations.

I at one point had done this, but for the life of me can't find my implementation. As I recall, it was pretty nasty and should be rewritten anyway.

Basically, what one has to do is the following:
1. Separate instrument labels (which have parentheses) from segment labels
2. Induce segment intervals from the event boundary markers
3. Partition segments by vocabulary for conversion.
4. If we're daring, also transfer the instrument annotations by matching parentheses.

1 and 2 should be easy. 3 I think can be easily achieved by a clever use of the JAMS namespace structure for each annotation, and a cunning use of pandas.

4 is tricky since you sometimes see open- and close-parens on the same event, and we'll need a namespace for the instruments.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.