marl / marl/GuitarSet

Incorrect timings in two annotations

Open
#5 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
173
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Firstly thank you to all the authors for making this available. Your work is still very much appreciated!

In working with the dataset we identified two alignments where all the notes appeared to be aligned to the second note onset, instead of the first note onset. This introduces a constant delay in the annotations rendering them inaccurate. The files are:

* `04_BN3-154-E_comp` (off by + 0.409s)
* `04_Jazz1-200-B_comp` (off by + 0.309s)

While it's possible to fix the annotations by subtracting those constants from all the timings, it would make fair comparison with current published results more challenging. Perhaps you could just leave a note somewhere on the Zenodo page? People might want to exclude those files from their training data for example.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the annotations for 04_BN3-154-E_comp and 04_Jazz1-200-B_comp, then check the dataset information on Zenodo. Done means the timing discrepancy is corrected in the released data or the affected files and offsets are clearly documented for users.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.