marko-js / marko-js/website

TS types missing for some code examples

Open
#127 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
9
Avg merge
1h 45m
Merged PRs (30d)
11

Description

https://markojs.com/docs/marko-run/file-based-routing#handler

Does these code examples don't need TS types? I tried them out and they are not type safe. no auto compilation, no nothing.

Image

for example the above can, based on the docs, gives you context, next but it's not type safe.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Marko Run file-based routing handler section at the linked documentation URL and reproduce the example in a TypeScript project. Check whether the documented context and next values receive types, then update the examples or their guidance so the documented code is type-safe and verify the examples compile.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.