marko-js / marko-js/run

`run-adapter-static` also creates dynamic directories names as static folders

Open
#64 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
175
Forks
17
Avg merge
5h 26m
Merged PRs (30d)
5

Description

https://github.com/Jack5079/marko-slug-bug

<!-- +page.marko -->
<a href="/path">path</a>
<!-- $+page.marko -->
<h1>here be $</h1>

Results in

dist
├── $
│   └── index.html
├── 404
│   └── index.html
├── path
│   └── index.html
└── index.html

But it should be:

dist
├── 404
│   └── index.html
├── path
│   └── index.html
└── index.html

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked reproduction and the run-adapter-static entry point, then run it and inspect the generated dist tree. The fix is done when the dynamic $ route no longer creates a $/index.html directory while the 404, path, and root outputs remain present.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.