marko-js / marko-js/run

`adapter-static` does not output to root of `dist` folder

Open
#172 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
175
Forks
17
Avg merge
5h 26m
Merged PRs (30d)
5

Description

I am using the default marko-run project with the adapter-static adapter.

When I try to run marko-run build, it will output the built files to dist/public. When I then upload the files to my file server, the front page of my website (example.com) will return a 404 error because there is nothing in the root folder. You must navigate to example.com/public to see the front page.

I think the behavior of the static adapter should be changed to always output files to the root folder. If you don't agree with that, I would request that you add an option to the configuration that allows me to put the files in the root folder.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the default marko-run project by running marko-run build using adapter-static, then inspect how the adapter chooses dist/public as its output location. Determine whether the intended behavior is root output or a configuration option, and verify that the built front page is served from the root of the uploaded files without a 404.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.