marko-js / marko-js/run

Incorrectly generating routes for nested dynamic segments where the first one is optional

Open
#110 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
175
Forks
17
Avg merge
5h 26m
Merged PRs (30d)
5

Description

Given the file

($one,).$two+page.marko

should generate routes

/$two
/$one/$two

but currently generates

/$one
/$one/$two

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the route-generation entry point for Marko files with nested dynamic segments, then reproduce the case using ($one,).$two+page.marko. Confirm the fix produces /$two and /$one/$two, rather than /$one and /$one/$two, and add or run the relevant route-generation test if one exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.