Invalid CommandEnv & os.Environ priority
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 196
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/markbates/refresh/blob/4a017449d85be7e77ec41bb7327e10151ffba6e0/refresh/runner.go#L48
Must be
```go
cmd.Env = append(os.Environ(), m.CommandEnv...)
```
because local variables should override global
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open refresh/runner.go at line 48 and inspect how CommandEnv is assigned to the command environment. Verify the intended precedence between os.Environ and CommandEnv, then confirm that local command variables override global values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100