markbates / markbates/jquery-bootstrap-pagination
It seems like that the option `display_max` does not work.
Open
Nobody has claimed this yet.
- Dominant language
- CoffeeScript
- Stars
- 89
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Description
The max page number displayed is still 10 while the total pages less than 10.And I looked at the code, should the 10 be max at line 93?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open vendor/assets/javascripts/jquery-bootstrap-pagination.js and inspect line 93, where the issue reports that a literal 10 is used despite the display_max option. Confirm how the max page value is passed through the pagination logic, then verify that the displayed page count respects display_max when the total pages are below 10.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- coffeescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100