markbates / markbates/jquery-bootstrap-pagination

The link "#" should be prevent for one page application.

Open
#11 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CoffeeScript
Stars
89
Forks
38
PR merge metrics
No merged PRs in 30d

Description

For one page application, the url "#" part means different route, so use this pagination will take to home page after run callback.

So it should add this code:

event.preventDefault();

in the PaginationView.prototype.clicked function.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at PaginationView.prototype.clicked, which the issue identifies as the change point. Add the requested event prevention there and verify that using pagination in a one-page application no longer navigates to the home page after the callback runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
coffeescript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.