Apple auth not fetching first name and last name even with the name scope
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.6k
- Forks
- 631
- PR merge metrics
- No merged PRs in 30d
Description
It seems like the first name and last name is not being fetched for Apple Sign-In even if the name scope has been specified. I tried looking at the code it mentioned: https://github.com/markbates/goth/blob/4b34e1719daae56def96b42ec23ca05badf6ca24/providers/apple/apple.go#L124-L130
Since CompleteUserAuth has access to the request, I was thinking that fetching the names should be possible, though there would be a change on the method signature of FetchUser.
Just wondering if the omission was more of a limitation or was this intentional? If it's a limitation with the current implementation I'd like to take a stab at implementing this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Apple provider code in apple/apple.go, especially the FetchUser code around the linked lines, then trace how CompleteUserAuth passes the request. Confirm how Apple exposes the name scope and determine the required FetchUser change. Done means first and last names are available after Apple Sign-In when that scope is requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100