markbates / markbates/goth

Is the provider URL necessary for logging out?

Open
#612 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6.6k
Forks
631
PR merge metrics
No merged PRs in 30d

Description

in the example code I see that we send the URL param for provider in the logout request

```go
p.Get("/logout/{provider}", func(res http.ResponseWriter, req *http.Request) {
gothic.Logout(res, req)
res.Header().Set("Location", "/")
res.WriteHeader(http.StatusTemporaryRedirect)
})

```
But I tried to do the same thing without passing the provider and the result seems to be identical. Am I missing something?

My usecase is trying to simplify logout logic when working with multiple providers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the example logout handler and the gothic.Logout call shown in the issue, then inspect how the provider URL is used during logout. Clarify whether the provider parameter is required, and update the relevant example or documentation so the expected behavior for multiple providers is explicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.