No documentation on why there is a defer logout
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.6k
- Forks
- 631
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/markbates/goth/blob/f4685f5f6edf65de920b6c6c03fc1ffabcb88e68/gothic/gothic.go#L180
`func CompleteUserAuth`
In this function, why is there a defer to Logout?
---
I've been trying to figure out why my use of gothic is returning a cookie (`_gothic_session`) with an expires of `"1970-01-01T00:00:01.000Z"`.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with gothic/gothic.go at the linked CompleteUserAuth function and inspect the deferred Logout behavior alongside the reported _gothic_session expiry. Document why Logout is deferred and clarify how that behavior relates to the cookie expiration, so the function's intent is understandable to users.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication, documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100