Apple login fails if user decides not to share Apple ID
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.6k
- Forks
- 631
- PR merge metrics
- No merged PRs in 30d
Description
Using the latest version of goth v1.79.0.
I found an error on some users attempting to login with Apple here and managed to reproduce it if on the step where apple asks you "Do you want to continue using App id for login with your Apple ID ?" and you click cancel. If user clicks continue on this flow everything works smoothly.
Scopes that I use are name and email, and I see that we already have some users in the database with hidden emails.
Removing the scopes also do not helps.
The error comes from [here](https://github.com/markbates/goth/blob/v1.79.0/providers/apple/session.go#L64)
Anyone have idea what's going on?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at providers/apple/session.go line 64 and reproduce the Apple login flow while declining to share the Apple ID. Trace the failure through the provider's cancellation path, then verify that login completes without the reported error for users whose email is hidden; add regression coverage if the repository's existing tests provide a suitable entry point.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100