wecom provider has bug. cached client will be using for everybody....
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.6k
- Forks
- 631
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/markbates/goth/blob/b5cb5a628f070880f909731a01c1952aaa494c46/providers/wecom/wecom.go#L124
wecom provider has bug. cached client will be using for everybody....
``` go
func (p *Provider) fetchToken() (*oauth2.Token, error) {
if p.token != nil && p.token.Valid() {
return p.token, nil
}
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with providers/wecom/wecom.go at fetchToken and trace how p.token is reused across requests. Done means the WeCom provider no longer reuses one cached client or token for everybody; add or update a focused regression test if provider tests are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100